-
Notifications
You must be signed in to change notification settings - Fork 57
Rename tracker mod to core #255
Copy link
Copy link
Closed
Labels
- Contributor -Nice to support TorrustNice to support TorrustCode Cleanup / RefactoringTidying and Making NeatTidying and Making NeatDocumentationImproves Instructions, Guides, and NoticesImproves Instructions, Guides, and NoticesNeeds FeedbackWhat dose the Community Think?What dose the Community Think?
Description
Activity
Metadata
Metadata
Assignees
Labels
- Contributor -Nice to support TorrustNice to support TorrustCode Cleanup / RefactoringTidying and Making NeatTidying and Making NeatDocumentationImproves Instructions, Guides, and NoticesImproves Instructions, Guides, and NoticesNeeds FeedbackWhat dose the Community Think?What dose the Community Think?
Type
Projects
- StatusShow more project fieldsNo status
I propose renaming the root module
trackertocore.Mod: https://github.com/torrust/torrust-tracker/tree/develop/src/tracker
That will allow having these namespaces:
core::tracker::Trackercore::peer::PeerIn my opinion, that's better than the:
tracker::Trackertracker::peer::PeerThe mod contains more things than just the tracker, and that
Trackercould even disappear in the future. I think what we have is the domain logic for BitTorrent trackers, regardless of which delivery mechanism you use (the way end-user interact with that domain logic).I'm writing the documentation for the crate, and it makes sense to give it a name to the "core" tracker logic.
If we move the mod to a package in the future, the name would be
torrust-tracker-trackerif we follow current conventions. I thinktorrust-tracker-corewould be a better name.I'm open to more options. I think
coremay be too generic.Other alternatives:
torrust-tracker-domaintorrust-bittorrent-trackerWe must consider that we also have another package called
sharedwith logic used by thecore,http,udp, ...cc @da2ce7 @WarmBeer