Skip to content

chore(lint-improvements): new eslint concept #6409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
zdunecki wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

chore(lint-improvements): new eslint concept #6409

zdunecki wants to merge 2 commits into from
+887 −447

Conversation

@zdunecki
Copy link

@zdunecki zdunecki commented Dec 30, 2025

Description

This PR introduces a new ESLint configuration concept that enforces consistent code style and import ordering across the Univer codebase.

Note

It's a concept only. If you like that, I can apply that to other packages.

Changes

  • ESLint Configuration Refactor: Reorganized rules into modular presets with comprehensive documentation
  • Import Ordering:
    • Type imports separated from value imports
    • Grouped by source: external → @univerjs → local
    • Added newlines between groups
  • Code Style: Fixed comma-dangle, indentation, and end-of-file newlines

Example Import Order

// Type imports
import type { IKeyValue } from '@univerjs/core';

// External packages
import { Disposable, EventSubject } from '@univerjs/core';

// Local alias type imports
import type { IButtonProps } from '@/components/button';

// Local alias imports
import { Button } from '@/components/button';

// Relative type imports
import type { IDragEvent } from './basics/i-events';

// Relative imports
import { CURSOR_TYPE } from './basics/const';

@zdunecki zdunecki requested review from Jocs and jikkai as code owners December 30, 2025 17:28
@github-actions
Copy link

github-actions bot commented Dec 30, 2025 •
edited
Loading

View Deployment

#20608468311

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@zdunecki zdunecki marked this pull request as draft December 30, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jocs Jocs Awaiting requested review from Jocs Jocs is a code owner

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zdunecki