feat(native): capture WER report ID to crash events - #1970
Open
jpnurmi wants to merge 9 commits into
Open
Conversation
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1970 +/- ##
==========================================
- Coverage 76.15% 76.13% -0.03%
==========================================
Files 94 94
Lines 22216 22231 +15
Branches 3941 3944 +3
==========================================
+ Hits 16919 16925 +6
- Misses 4411 4420 +9
Partials 886 886 🚀 New features to boost your workflow:
|
Capture WER report ID into the shared memory, and expose it as `contexts.wer.report_id` in crash events.
Regular SEH crashes kept the crashing process alive until the daemon had already serialized the event. Windows invokes the WER callback only after the exception filter returns, so the callback could not publish its report ID to shared memory in time. Add an intermediate PROCESSED state so the daemon can finish reading process-dependent crash data, release the SEH handler, and then wait for the WER callback before serializing the event. Record whether WER was registered to avoid waiting when no callback can arrive, and retain the existing timeout as a fallback. The integration test now requires every captured native WER event to contain a report ID and verifies that it matches WER's ReportIdentifier.
jpnurmi
force-pushed
the
jpnurmi/feat/wer-report-id
branch
from
August 10, 2026 11:29
3560db1 to
d263703
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 58e6929. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture WER report ID into the shared memory, and expose it as
contexts.wer.report_idin crash events.https://sentry-sdks.sentry.io/issues/7663645167
See also: