Skip to content

feat: implement Write handler for E2E file write #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tejas-claude-bot wants to merge 17 commits into
base: main
Choose a base branch
from
Open

feat: implement Write handler for E2E file write #21

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
39944dc
feat: implement Close, Read, and QueryInfo handlers for E2E file read
tejas-claude-bot[bot] Feb 8, 2026
f2fe296
fix: resolve file read integration test failures
tejas-claude-bot[bot] Feb 10, 2026
09ea922
refactor: replace raw Vec<u8> info buffers with typed MS-FSCC structs
tejas-claude-bot[bot] Feb 10, 2026
56eb98e
refactor: split file_info structs into separate files per project con…
tejas-claude-bot[bot] Feb 12, 2026
27765c8
fix: correct FileId construction, close cleanup, and DurableFileId ve…
tejas-claude-bot[bot] Mar 29, 2026
f04b7b4
refactor: replace manual FileAllInformation::to_bytes() with SMBToByt…
tejas-claude-bot[bot] Mar 29, 2026
a806452
refactor: replace raw u32 fields with typed bitflags/enums in file_info
tejas-claude-bot[bot] Mar 31, 2026
73e40d1
fix: address security bugs and encapsulate struct fields
tejas-claude-bot[bot] Apr 4, 2026
2fa3140
fix: resolve clippy warnings from rebase
tejas-claude-bot[bot] Apr 5, 2026
7ccb0b1
fix: create response after open registration, handle short reads, and…
tejas-claude-bot[bot] Apr 7, 2026
d19dd86
fix(clippy): gate SMBByteSize import and suppress unused variable war…
tejas-claude-bot[bot] Apr 7, 2026
96adf53
feat: implement Write handler for E2E file write
tejas-claude-bot[bot] Apr 5, 2026
d85e689
test: add E2E smbclient tests for Write handler
tejas-claude-bot[bot] Apr 5, 2026
f72b568
test: remove #[ignore] from smbclient integration tests
tejas-claude-bot[bot] Apr 5, 2026
8e7cbea
fix: use write_all to prevent short writes and add write_data tests
tejas-claude-bot[bot] Apr 7, 2026
1a1c606
fix: truncate existing files on FILE_OVERWRITE_IF create disposition
claude Jul 16, 2026
7e2a15a
test: skip smbclient E2E tests when prerequisites are missing
claude Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: replace raw Vec<u8> info buffers with typed MS-FSCC structs 
Introduce protocol::body::file_info module with proper typed structs for
MS-FSCC file information classes:
- FileBasicInformation (2.4.7)
- FileStandardInformation (2.4.41)
- FileInternalInformation (2.4.20)
- FileEaInformation (2.4.12)
- FileAccessInformation (2.4.1)
- FilePositionInformation (2.4.35)
- FileModeInformation (2.4.26)
- FileAlignmentInformation (2.4.3)
- FileNameInformation (2.4.28)
- FileNetworkOpenInformation (2.4.29)
- FileAllInformation (2.4.2)

All types use SMBFromBytes/SMBToBytes/SMBByteSize derive macros for
automatic serialization, replacing manual Vec<u8> byte-pushing in
tree_connect.rs build_file_* methods.

Includes 14 unit tests (round-trip serialization + size assertions).
All 80 unit tests and 10 integration tests pass.
  • Loading branch information
@tejas-claude-bot
tejas-claude-bot[bot] committed Apr 4, 2026
commit 09ea9220a92450f1c168f24504352bbdca60c3e2
Loading