fix: Prevent PostsIterator from resetting the post global in the admin#3117
Draft
fix: Prevent PostsIterator from resetting the post global in the admin#3117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When calling
Timber::get_posts()in the admin, Timber will call$post->setup()for all posts, which will cause the$postglobal to be overwritten. This intended when looping over posts in the frontend, but it shouldn’t be done in the WordPress admin. Because there it can mess up your posts.For example, you could open a post in the block editor and the content of a different post is loaded in there.
Solution
Add a check to only run the
setup()in the frontend.Impact
Fewer side-effects.
Usage Changes
None.
Considerations
I’m not sure whether the
template_redirecthook is the right check. That’s why I’m opening this pull request as a draft first.We surely need to check how this would different ways of accessing the post content, e.g. through the REST API.
Testing
Not yet.