This repository was archived by the owner on May 3, 2024. It is now read-only.
Conversation
|
We're building your pull request over on Zeet. |
- minting an nft where the metadata[“image”] is a file results in that property being replaced with the IPFS hash and the image gets uploaded - minting an nft where the metadata[“image”] is a string just uploads the metadata like normal
atbe
reviewed
Nov 16, 2021
atbe
reviewed
Nov 16, 2021
atbe
reviewed
Nov 16, 2021
atbe
reviewed
Nov 16, 2021
atbe
reviewed
Nov 16, 2021
atbe
reviewed
Nov 16, 2021
…)` in `is_approved` fixed approve error for `create_with_erc20` and `create_with_erc721` todo: `721` method still throws `thirdweb_web3.exceptions.ContractLogicError: execution reverted`
atbe
reviewed
Nov 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.