LLEXT: Minor improvements#9703
Merged
Merged
Conversation
lyakh
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Use section offset from the section header in llext_manager_load_data_from_storage() to simplify calculations and eliminate a function parameter. Signed-off-by: Guennadi Liakhovetski <[email protected]>
file_offset in struct lib_manager_segment_desc is unused, remove it. Signed-off-by: Guennadi Liakhovetski <[email protected]>
We don't need to store .bss address and size until the module is freed since .bss is allocated together with .data and we only need its size when initialising it, not when freeing module memory. Remove it to save memory. Signed-off-by: Guennadi Liakhovetski <[email protected]>
free(NULL) is allowed, remove redundant checks. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Remove unused arguments from llext_manager_load_module(), llext_manager_unload_module() and llext_manager_link(). Signed-off-by: Guennadi Liakhovetski <[email protected]>
Zephyr logging prints function names, no need to include them explicitly. Signed-off-by: Guennadi Liakhovetski <[email protected]>
llext_manager_allocate_module() should return 0 when failing, not an error code. Signed-off-by: Guennadi Liakhovetski <[email protected]>
Collaborator
Author
|
https://sof-ci.01.org/sofpr/PR9703/build9630/devicetest/index.html unfortunately only tested SDW, we need HDA tested, restart SOF CI |
Collaborator
Author
|
SOFCI TEST |
Collaborator
Author
|
A few failures on LNL, but supposedly all known https://sof-ci.01.org/sofpr/PR9703/build9638/devicetest/index.html |
kv2019i
approved these changes
Dec 3, 2024
kv2019i
left a comment
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
Good fixes and easy to follow commit messages!
lgirdwood
approved these changes
Dec 3, 2024
Collaborator
|
sof-docs fail and Intel LNL fails all known and tracked in https://github.com/thesofproject/sof/issues?q=is%3Aissue+is%3Aopen+label%3A%22Known+PR+Failures%22+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several minor fixes and improvements from #9688