Free a couple of memory leaks in the SOF plugin#9055
Merged
Conversation
ranj063
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
kv2019i
reviewed
Apr 17, 2024
kv2019i
left a comment
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
One comment to first patch, otherwise looks good.
| if (available_fmts->output_pin_fmts) | ||
| free(available_fmts->output_pin_fmts); | ||
| if (available_fmts->input_pin_fmts) | ||
| free(available_fmts->input_pin_fmts); |
Collaborator
There was a problem hiding this comment.
Isn't this if-check redundannt, NULL is ok to free
Collaborator
Author
not yet @lgirdwood. Im working to get there |
abonislawski
approved these changes
Apr 18, 2024
lgirdwood
reviewed
Apr 18, 2024
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
Should these 2 patches be squashed ?
Member
|
@ranj063 ping. |
Member
|
@ranj063 ping |
Free the memory allocated for tplg base and available input/output formats when the topology is freed. Signed-off-by: Ranjani Sridharan <[email protected]>
Collaborator
Author
Sorry for the delay @lgirdwood . Fixed now |
kv2019i
approved these changes
Jun 14, 2024
Collaborator
|
@wszypelt Can you check? This seems to be stuck.. |
Collaborator
|
@kv2019i after checking the tests, one issue appeared, which is sporadic and it has nothing to do with PR, in my opinion you can merge, but if you still have about an hour, the result should already be green |
singalsu
added a commit
to singalsu/sof
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Seppo Ingalsuo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.