Host always set to localhost#145
Merged
tillahoffmann merged 1 commit intomasterfrom Aug 15, 2021
unknown repository
Merged
Conversation
the host will correctly be assigned in `_create_connection_url` using `get_container_host_ip`
ghost
mentioned this pull request
nourfaroualx
approved these changes
Jul 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment using a host other than localhost will fail because generic.py line 26 calls self.get_connection_url() without a host param which defaults to localhost.
This PR corrects this by setting host to None per default. The host will then correctly be assigned in _create_connection_url using get_container_host_ip.