Remove useless whitespace in Websocket output (backport #9720) - #9723
Open
mergify[bot] wants to merge 2 commits into
Open
mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
* First try at #9696 * Brief explanation * Removed all prettified JSON RPC responses * Fixes for failing tests. Adapted the assertions in - TestWriteRPCResponseHTTP - TestWriteRPCResponseHTTPError to work with non-pretty JSON-RPC output * Added changelog pending entry * Update CHANGELOG_PENDING.md Co-authored-by: Thane Thomson <[email protected]> (cherry picked from commit 20ffa4f) # Conflicts: # CHANGELOG_PENDING.md # rpc/jsonrpc/server/http_server_test.go
Contributor
|
@Mergifyio backport mergify/bp/v0.37.x/pr-9650 |
Contributor
Author
🟠 Waiting for conditions to matchDetails
|
thanethomson
added
the
S:wip
Contributor
|
@Mergifyio rebase v0.37.x |
Contributor
Author
✅ Nothing to do for rebase action |
Contributor
|
This PR should be rebased after we merge #9665. That should fix the conflicts. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #9720 done by Mergify.
Cherry-pick of 20ffa4f has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com