Skip to content

chore(kit): ProgressColorSegments has change detection problems in legacy Angular#13630

Open
nsbarsukov wants to merge 2 commits intov4.xfrom
v4-progress-segmented-fix-again
Open

chore(kit): ProgressColorSegments has change detection problems in legacy Angular#13630
nsbarsukov wants to merge 2 commits intov4.xfrom
v4-progress-segmented-fix-again

Conversation

@nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Mar 26, 2026 •
edited
Loading

Previous behavior

previous

New behavior

new

NOT relevant for main branch and Angular 19+!
https://taiga-ui.dev/components/progress-segmented#colors

@nsbarsukov nsbarsukov self-assigned this Mar 26, 2026
@nsbarsukov nsbarsukov requested a review from a team as a code owner March 26, 2026 09:54
@nsbarsukov nsbarsukov requested review from MarsiBarsi, mdlufy, sayranovv, vladimirpotekhin and waterplea and removed request for a team March 26, 2026 09:54
@github-actions github-actions bot added the v4 label Mar 26, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2026 •
edited
Loading

Failed tests ❌

Before (main) ← Diff → After (local)

tests-demo-demo.pw-Demo-components-progress-segmented-chromium-retry2/components-progress-segmented/3.android.diff.png
tests-demo-demo.pw-Demo-components-progress-segmented-chromium-retry2/components-progress-segmented/3.desktop-rtl.diff.png
tests-demo-demo.pw-Demo-components-progress-segmented-chromium-retry2/components-progress-segmented/3.desktop.diff.png
tests-demo-demo.pw-Demo-components-progress-segmented-chromium-retry2/components-progress-segmented/3.ios.diff.png
tests-addon-preview-previe-32285--be-zoomed-via-wheel-scroll-chromium-retry2/01-preview-zoom-by-wheel.diff.png

(updated for commit 853582b)

@codecov
Copy link

codecov bot commented Mar 26, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.13%. Comparing base (111ac46) to head (853582b).

Additional details and impacted files 
@@           Coverage Diff            @@
##             v4.x   #13630    +/-   ##
========================================
  Coverage   63.12%   63.13%            
========================================
  Files        1405     1405            
  Lines       19574    19576     +2     
  Branches     3178     3076   -102     
========================================
+ Hits        12357    12359     +2     
- Misses       6662     6887   +225     
+ Partials      555      330   -225
Flag Coverage Δ
summary 63.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2026 •
edited
Loading

Visit the preview URL for this PR (updated for commit 853582b):

https://taiga-previews-demo--pr13630-v4-progress-segmented-fix-k7is2i6v.web.app

(expires Fri, 27 Mar 2026 13:15:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

@bundlemon
Copy link

bundlemon bot commented Mar 26, 2026 •
edited
Loading

BundleMon

Files added (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 +362.4KB +10%
✅ demo/browser/vendor.(hash).js
 +312.42KB +10%
✅ demo/browser/runtime.(hash).js
 +55.7KB +10%
✅ demo/browser/styles.(hash).css
 +24.94KB +10%
✅ demo/browser/polyfills.(hash).js
 +11.16KB +10%

Total files change +766.62KB

Groups added (1)
Status Path Size Limits
✅ demo/browser/*..js
 +10.34MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2026 •
edited
Loading

Playwright test results

failed  2 failed
passed  1738 passed
skipped  20 skipped

Details

report  Open report ↗︎
stats  1760 tests across 95 suites
duration  19 minutes, 48 seconds
commit  853582b

Failed tests

chromium › tests/addon-preview/preview.pw.spec.ts › Preview › Examples › Preview can be zoomed via wheel scroll
chromium › tests/demo/demo.pw.spec.ts › Demo › /components/progress-segmented

Skipped tests

chromium › tests/core/dropdown/dropdown.pw.spec.ts › Dropdown › Esc -> Hosted Dropdown
chromium › tests/demo/source-code-link.pw.spec.ts › Source code button › /variables
chromium › tests/demo/source-code-link.pw.spec.ts › Source code button › /appearances
chromium › tests/demo/source-code-link.pw.spec.ts › Source code button › /portals
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputCard › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputCard › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputCard › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputInline › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputInline › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputInline › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputPin › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputPin › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputPin › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputFiles › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputFiles › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › InputFiles › update on submit
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › Textfield › update on change
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › Textfield › update on blur
chromium › tests/inputs/update-on.pw.spec.ts › Inputs - updateOn › Textfield › update on submit
chromium › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › non-erasable minus (as [prefix]) for [max] <= 0 › forbids to enter more minuses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waterplea waterplea waterplea left review comments

@splincode splincode splincode approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

@sayranovv sayranovv Awaiting requested review from sayranovv sayranovv is a code owner automatically assigned from taiga-family/core-team

At least 2 approving reviews are required to merge this pull request.

Assignees

@nsbarsukov nsbarsukov

Labels

v4

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nsbarsukov @waterplea @splincode