Fix typings for clean run in mypy - #982
Merged
Merged
Conversation
Contributor
|
Awesome. Once this gets merged, I'll rebase my other open PRs. |
t8y8
approved these changes
Jan 31, 2022
jacalata
added a commit
that referenced
this pull request
Mar 30, 2022
* fix types for get-users-for-group * make capability elements non-optional * turn groups into reference_resources * plus run black formatter * remove untyped empty list assigned to iterator and now mypy should run clean!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
probably introduced these failures in merge mistakes when I merged all those type-hints at once.