Adding Webhooks documentation - #1084
Merged
Merged
Conversation
Contributor
Author
|
Hey @bcantoni and @jacalata . I added webhooks documentation. Please take a look and let me know what you think. In addition to the overall review, here are a few things I did differently, let me know if these are ok:
This is my first attempt at TSC doc - so look forward to any feedback on what I can do to improve and help make this review process easy for you, or anything else. |
Closed
bcantoni
requested changes
Aug 2, 2022
bcantoni
reviewed
Aug 2, 2022
Removing --- from code blocks per Brain's review
Adding a space between "=" and adding a line before print statements
jacalata
approved these changes
Aug 5, 2022
…ency) and recommendation for using short event name
kramantab
commented
Aug 5, 2022
Contributor
Author
bcantoni
approved these changes
Aug 5, 2022
bcantoni
left a comment
bcantoni
left a comment
Contributor
There was a problem hiding this comment.
@kramantab everything looks good to me. The Gemfile got broken again to something else, so I just pushed to your branch to fix it back. If you do a git pull on your side, you'll have the same in your local copy.
Contributor
Author
|
Squashing the commits and doing a merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # 739
[Issue 739](url)