Use defusedxml library to reduce xml attack surface - #1002
Merged
Conversation
had to manually undo some of the changes to keep mypy happy
RequestFactory and RequestOptions are used everywhere, should really be in a separate module
ovinis
approved these changes
Mar 11, 2022
ovinis
left a comment
ovinis
left a comment
Contributor
There was a problem hiding this comment.
Thanks for updating the library. I think this also addresses Tabcmd issue that was logged for TSC tableau/tabcmd#15
jacalata
added a commit
that referenced
this pull request
Mar 30, 2022
replace ET.fromstring with defusedxml.fromstring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#988
from https://pypi.org/project/defusedxml/, we need to make sure we call defusedxml.ElementTree instead of xml.etree.ElementTree for these methods: parse(), iterparse(), fromstring(), XMLParser
the only one of those we call is fromstring()