Handling close events properly - #8
Merged
Merged
Conversation
Fix typo in SockJS.cs Fire close event in WebSocketTransport.cs (as in original sockjs implementation)
doronguttman
requested changes
Dec 31, 2019
doronguttman
left a comment
doronguttman
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the pull request!
please remove items not related to specific issue at hand (e.g. nuget files, etc.)
dguttman-jacada
approved these changes
Jan 2, 2020
Contributor
|
@DenisBalan I'd like to officially publish the repo to nuget, however, it looks like you have taken control of the name. can you please do a PR for the publication and release the name? thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add WebSocketMessageType.Close handling in WebSocketDriver.cs
Fix typo in SockJS.cs
Fire close event in WebSocketTransport.cs (as in original sockjs implementation)