Skip to content

attachable classes #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aryarm merged 9 commits into from
Mar 21, 2019
Merged

attachable classes #137

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fd9dc70
create class status column
aryarm Feb 23, 2019
1e1e949
modify ResourceClass seeder to adhere to new class status column
aryarm Feb 23, 2019
0720680
fix small bug in ResourceController attach validation
aryarm Feb 23, 2019
9548b50
send status in tree data
aryarm Feb 23, 2019
0c3bf28
send status in class json request
aryarm Feb 24, 2019
dd7b541
make class_id a required attribute of resource creation
aryarm Feb 24, 2019
32df02b
405 errors should be 403
aryarm Feb 24, 2019
8f28918
make resource-class detachment semi future-proof in case we have more…
aryarm Feb 24, 2019
4b3a796
test the resource controller now that it has a new status attribute
aryarm Feb 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
405 errors should be 403
  • Loading branch information
@aryarm
aryarm committed Feb 24, 2019
commit 32df02bd57e8dd92fcaec75ec3370124438e4444
4 changes: 2 additions & 2 deletions app/Http/Controllers/ClassController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,12 @@ public function destroy(Academic_Class $class)
// before deleting the class, make sure it doesn't have any classes attached underneath it
if ($class->children()->count() > 0)
{
abort(405, "You cannot delete a class that has children");
abort(403, "You cannot delete a class that has children");
}
// also make sure it doesn't have any resources attached to it
if ($class->resources()->count() > 0)
{
abort(405, "You cannot delete a class that has resources");
abort(403, "You cannot delete a class that has resources");
}
// actually delete the class
$class->delete();
Expand Down
2 changes: 1 addition & 1 deletion app/Http/Controllers/ResourceController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ public function detach(Resource $resource, Request $request){
}
else
{
abort(405, "Detaching this resource will attach it to the root, which is currently not allowed.");
abort(403, "Detaching this resource will attach it to the root, which is currently not allowed.");
}
}
}
Expand Down