Various fixes for building with new compilers #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: starseeker <[email protected]>
Co-authored-by: starseeker <[email protected]>
…arations Co-authored-by: starseeker <[email protected]>
Improves error handling in STEPattributeList operator[] - return an error attribute and set error state rather than trying to rely on crashing via a NULL deference. That's undefined behavior, so it was not guaranteed - this requires the calling code to check the return, but is *much* cleaner. Co-authored-by: starseeker <[email protected]>
Co-authored-by: starseeker <[email protected]>
Member
|
Does the latest EXPRESS compiler updates successfully compile the AP 242 ed4 long form schema: |
…ype-andor Fix test_exppp_supertype_andor CMake version inconsistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as one behavior correction - rather than trying to use a NULL pointer deference to crash in an error case (bad practice and undefined behavior anyway) return an error attribute calling applications can deal with gracefully.