-
Notifications
You must be signed in to change notification settings - Fork 129
Tp/python generator dev #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Updated SCL unittest.
|
Great! I will test this today, and if all goes well I will merge it and bump the version to 0.5 |
|
You should test that:
|
|
I recently worked on SELECT type support. You can also check that the following test pass: $ cd src/fedex_python/examples/unitary_schemas
$ python
> from test_select_data_type import *
> the_glue = glue(STRING("the composition"), STRING("the solvent"))
> wm = wall_mounting(STRING("mounting"), STRING("on"), the_glue)
> print wm
This should not raise any exception. |
|
I committed 3 more changes. It should be ok now. As soon as this branch is merged, I will create a tp/python-generator-dev-stage2 branch to go on with development. I think I understood how to deal with type checking, aggregates and constructed data types. I have to clean up the current implementation and I will focus on STEP AP. |
Is that what you meant when you wrote "I just realize that one test does not pass because of a method renaming that was not propagated"? The rest looks good to me. In your next branch, what about configuring CMake such that |
|
@mpictor I removed the buggy test. It is related to a feature that is not completed: type casting from python objects to EXPRESS types. For instance, I'd like to be able to cast floats to REAL, ints to INTEGER type, list to LIST and ARRAY types etc. It's useful when the target type is not known, for instance when creating instances from a p21 file (the Part21 stuff is not finished yet). |
|
@mpictor I agree with your |
There were many improvements recently committed, regarding SELECT and ENUMERATION constructed data types. The resolution order issue was also solved. I wish I had more time to review/test what was achieved before releasing, many parts of the code are still missing or partly implemented. Anyway, it can be integrated as is, further developments will come over this first release.