Add threshold (fuzzy match) parameters in match_text#460
Open
sc-stbt wants to merge 2 commits intostb-tester:mainfrom
Open
Add threshold (fuzzy match) parameters in match_text#460sc-stbt wants to merge 2 commits intostb-tester:mainfrom
sc-stbt wants to merge 2 commits intostb-tester:mainfrom
Conversation
added 2 commits
October 15, 2017 19:40
Sometime match_text did not find text, we added a threshold to be more flexible. it is reproduced on special caracters. we based on fuzzy match. I added unidecode lib, may be there is some impact.
Contributor
The unit tests fail because you've added a new dependency What problem does this new dependency solve? Would it be possible to add the fuzzy_match functionality without adding a new dependency? |
Author
|
Sorry for the delay, I was busy with other urgent task. |
drothlis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a d fuzzy_match based on difflib to tolerate wrong matching specially in special character.
I add unidecode on _hocr_find_phrase function.