Skip to content

feat: v0.1 conformances - #90

Merged
gadomski merged 17 commits into
mainfrom
conformance
Apr 18, 2025
Merged

feat: v0.1 conformances#90
gadomski merged 17 commits into
mainfrom
conformance

Conversation

@gadomski

@gadomski gadomski commented Apr 3, 2025

Copy link
Copy Markdown
Member

What I'm changing

  • Add STAPI v0.1 conformances

How I did it

  • Refactor conformances into API and PRODUCT dictionaries
  • Use conformance in more places to check for validity of requests and routes, etc
  • Add a check to make sure at least one geojson conformance is enabled on the product

Note

There's some TODOs and FIXMEs in here, so please just request changes if you'd like those resolved before we merge. My thought was to get a release out sortof in-sync w/ v0.1, so this could be considered "good enough"?

Checklist

  • Tests pass: uv run pytest
  • Checks pass: uv run pre-commit --all-files
  • CHANGELOG is updated (if necessary)

@gadomski
gadomski requested a review from jkeifer April 3, 2025 17:06
@gadomski gadomski self-assigned this Apr 3, 2025
@gadomski gadomski linked an issue Apr 3, 2025 that may be closed by this pull request
@gadomski gadomski added this to the v0.1 milestone Apr 3, 2025
Comment thread stapi-fastapi/src/stapi_fastapi/models/product.py Outdated
Comment thread stapi-fastapi/src/stapi_fastapi/routers/product_router.py Outdated
@gadomski
gadomski requested a review from jkeifer April 17, 2025 18:33
@jkeifer

jkeifer commented Apr 17, 2025

Copy link
Copy Markdown
Member

@gadomski I wrote up some comments then decided instead I'd just show you what I was thinking. Please see #98 for my ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conformance re-work

2 participants