refactor(ui): Inline Horizontal Navigation #18429
Draft
+218
−451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at ab66825. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18429 +/- ##
==========================================
- Coverage 48.93% 48.93% -0.01%
==========================================
Files 2631 2631
Lines 197964 197964
==========================================
- Hits 96868 96864 -4
- Misses 93707 93710 +3
- Partials 7389 7390 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dvail
force-pushed
the
dv/refactor-simplify-nav
branch
from
7763780 to
ab66825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplified version of #18413. Simply render the Nav inline at a slightly lower level of the component tree.
The main downside from this that I can see is that under VM, the navigation flickers and disappears when navigating between pages. This is because the Image/Node/Platform/VM CVEs are all at a different level of the route hierarchy, so we are essentially getting a new page even if the layout remains the same.
Core component:
Typical usage:
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!