Skip to content

ROX-32559: Render CompoundSearchFilterLabels in miscellaneous routes #18428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pedrottimark wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ROX-32559: Render CompoundSearchFilterLabels in miscellaneous routes #18428

pedrottimark wants to merge 1 commit into from

Conversation

@pedrottimark
Copy link
Contributor

@pedrottimark pedrottimark commented Jan 9, 2026 •
edited
Loading

Description

Objective: Use search filter config plus separate attributes as single source of truth.

Bonus: Render Label and LabelGroup instead of deprecated Chip and ChipGroup elements.

User-facing documentation

  • CHANGELOG.md update is not needed
  • documentation PR is not needed

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  1. npm run tsc in ui/apps/platform folder.
  2. npm run lint:fast-dev in ui/apps/platform folder.
  3. npm run start in ui/apps/platform folder with staging demo as central.

Manual testing

  1. Visit /main/clusters

    https://github.com/stackrox/stackrox/blob/master/ui/apps/platform/src/Containers/Clusters/ClustersTablePanel.tsx

    Select Cluster Name category with staging-secured-cluster value, and then Cluster Status category with Healthy and Degraded values.

    Search query in page address: s[Cluster][0]=staging-secured-cluster&s[Cluster%20status][0]=HEALTHY&s[Cluster%20status][1]=DEGRADED
    Search query in data request: Cluster:staging-secured-cluster+Cluster status:HEALTHY,DEGRADED
    Filter labels: Cluster name staging-secured-cluster and Cluster status Healthy Degraded

    Before change, with Chip and ChipGroup elements:
    ClustersTablePanel_Chip

    After change, with Label and LabelGroup elements:
    ClustersTablePanel_Label

  2. Visit /main/policy-management/policies

    https://github.com/stackrox/stackrox/blob/master/ui/apps/platform/src/Containers/Policies/Table/PoliciesTable.tsx

    Select Policy Status category with Enabled value.

    Search query in page address: s[Disabled][0]=false
    Search query in data request: Disabled:false
    Filter labels: Status Enabled

    Before change, with Chip and ChipGroup elements:
    PoliciesTable_Chip

    After change, with Label and LabelGroup elements:
    PoliciesTable_Label

  3. Visit /main/violations

    https://github.com/stackrox/stackrox/blob/master/ui/apps/platform/src/Containers/Violations/ViolationsTableSearchFilter.tsx

    Select Policy Severity category with Critical and High values.

    Search query in page address: s[Severity][0]=CRITICAL_SEVERITY&s[Severity][1]=HIGH_SEVERITY
    Search query in data request: Severity:CRITICAL_SEVERITY,HIGH_SEVERITY
    Filter labels: Policy severity Critical High

    Before change, with Chip and ChipGroup elements:
    ViolationsTableSearchFilter_Chip

    After change, with Label and LabelGroup elements:
    ViolationsTableSearchFilter_Label

@pedrottimark pedrottimark requested a review from a team as a code owner January 9, 2026 20:03
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jan 9, 2026

Images are ready for the commit at 7c794c0.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-741-g7c794c0754.

@codecov
Copy link

codecov bot commented Jan 9, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.89%. Comparing base (807b96c) to head (7c794c0).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #18428      +/-   ##
==========================================
- Coverage   48.89%   48.89%   -0.01%     
==========================================
  Files        2629     2629              
  Lines      197912   197912              
==========================================
- Hits        96766    96760       -6     
- Misses      93763    93768       +5     
- Partials     7383     7384       +1
Flag Coverage Δ
go-unit-tests 48.89% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci
Copy link

openshift-ci bot commented Jan 9, 2026

@pedrottimark: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-ui-e2e-tests 7c794c0 link true /test gke-ui-e2e-tests
ci/prow/ocp-4-20-ui-e2e-tests 7c794c0 link false /test ocp-4-20-ui-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pedrottimark
Copy link
Contributor Author

pedrottimark commented Jan 10, 2026 •
edited
Loading

ui-e2e-test failure fix in progress independent of changes to Clusters, Policies, Violations

Workload CVE overview page tests Layer type filter tests should apply Layer type filter correctly

Expected to find element: .pf-v5-c-toolbar .pf-v5-c-toolbar__group[aria-label="applied search filters"] .pf-v5-c-chip-group *:contains("Image component layer type")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pedrottimark @rhacs-bot