ROX-32557: Update Base Images permission to ImageAdministration #18415
+42
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at 64b712a. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18415 +/- ##
==========================================
- Coverage 48.93% 48.93% -0.01%
==========================================
Files 2631 2631
Lines 197964 197964
==========================================
- Hits 96872 96868 -4
- Misses 93703 93708 +5
+ Partials 7389 7388 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sachaudh
force-pushed
the
ROX-32557-update-base-images-permission
branch
from
7b11122 to
623aa05
Compare
pedrottimark
approved these changes
Jan 9, 2026
Contributor
Author
|
Tests should be resolved once #18422 goes in. The reason is explained in this comment: #18422 (comment) |
Signed-off-by: Saif Chaudhry <[email protected]>
Signed-off-by: Saif Chaudhry <[email protected]>
Signed-off-by: Saif Chaudhry <[email protected]>
sachaudh
force-pushed
the
ROX-32557-update-base-images-permission
branch
from
623aa05 to
64b712a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the UI permission check for the Base Images route from
ImagetoImageAdministrationto align with the backend.Additionally, restricts modification actions (add, edit, delete) to users with write access for
ImageAdministration. Users with read-only access will see a read-only view of the base images table.User-facing documentation
Testing and quality
ROX_BASE_IMAGE_DETECTIONfeature flagAutomated testing
How I validated my change
Screenshots
No Read/Write Access
Read Access Only
Read/Write Access