tidb: fix wrong type judgement and analyze index #1273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkingrei
force-pushed
the
fix_analyze_primary_key
branch
2 times, most recently
from
c718f96 to
944a393
Compare
mrigger
reviewed
Sep 15, 2025
Contributor
mrigger
left a comment
mrigger
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR! Would it be possible to pin a specific TiDB version?
.github/workflows/main.yml
Outdated
| run: | | ||
| docker pull pingcap/tidb:v8.5.2 | ||
| docker run --name tidb-server -d -p 4000:4000 pingcap/tidb:v8.5.2 | ||
| docker pull hawkingrei/tidb-playground:nightly |
Contributor
There was a problem hiding this comment.
It would be better to pin the currently supported version to a specific version. Would this be possible?
Collaborator
Author
There was a problem hiding this comment.
Yes, I updated it and pinned it to a specific version.
hawkingrei
force-pushed
the
fix_analyze_primary_key
branch
2 times, most recently
from
5d7778c to
968bb04
Compare
Collaborator
Author
Yes, I updated it and pinned it to a specific version. |
Contributor
|
Okay, thanks! Currently, the formatter test is failing. Could you please execute |
Signed-off-by: Weizhen Wang <[email protected]>
hawkingrei
force-pushed
the
fix_analyze_primary_key
branch
from
968bb04 to
d048353
Compare
Collaborator
Author
Thanks, I have fixed the format problem. |
Contributor
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that there were some errors displayed in the TiDB tests, and I have fixed them:
ANALYZE INDEX PRIMARY.