Merged
Conversation
in SpotifyApi; if not called, default is BasicHttpClientConnectionManager
and eliminated setConnectionManager()
…lean and restored previous SpotifyApi.build() with no parameter
…oolingConnectionManager
…ager/builder feat(http-manager)!: default to configurable pooling connection manager
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #410 +/- ##
============================================
+ Coverage 66.29% 66.33% +0.04%
Complexity 669 669
============================================
Files 184 184
Lines 7117 7105 -12
Branches 1147 1145 -2
============================================
- Hits 4718 4713 -5
+ Misses 1495 1490 -5
+ Partials 904 902 -2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default client connection manager of the
SpotifyHttpManageris aPoolingHttpClientConnectionManagernow instead of aBasicHttpClientConnectionManager. TheSpotifyHttpManager'sconnectTimeoutproperty is removed as it's not available on thePoolingHttpClientConnectionManager.