Unconditional while loops no raising IL_INFINITE_LOOP (#3537)

gtoison · web-flow · commit 423f1d1858b9 · 2025-10-17T15:13:41.000+02:00
* test: reproducer for issue #3460 * fix: document that unconditional loops are assumed to be intentional
diff --git a/spotbugs-tests/src/test/java/edu/umd/cs/findbugs/detect/Issue3460Test.java b/spotbugs-tests/src/test/java/edu/umd/cs/findbugs/detect/Issue3460Test.java
@@ -0,0 +1,15 @@
+package edu.umd.cs.findbugs.detect;
+
+import edu.umd.cs.findbugs.AbstractIntegrationTest;
+import org.junit.jupiter.api.Test;
+
+class Issue3460Test extends AbstractIntegrationTest {
+
+    @Test
+    void testIssue() {
+        performAnalysis("infiniteLoop/Issue3460.class");
+
+        // unconditional loops are assumed to be intentional
+        assertBugTypeCount("IL_INFINITE_LOOP", 0);
+    }
+}
diff --git a/spotbugs/etc/messages.xml b/spotbugs/etc/messages.xml
@@ -2259,7 +2259,7 @@ visible), they could trigger listener notification on the event dispatch thread.
     <Details>
 <![CDATA[
 <p>This loop doesn't seem to have a way to terminate (other than by perhaps
-throwing an exception).</p>
+throwing an exception). Unconditional loops such as <code>while (true) {...}</code> are assumed to be intentional and are not reported as bugs.</p>
 <p>See <a href="https://cwe.mitre.org/data/definitions/835.html">CWE-835: Loop with Unreachable Exit Condition ('Infinite Loop')</a>.
 </p>
 ]]>
diff --git a/spotbugs/etc/messages_fr.xml b/spotbugs/etc/messages_fr.xml
@@ -956,7 +956,7 @@ Un accesseur sp&eacute;cial est g&eacute;n&eacute;r&eacute; dans ce cas par la compilateur pour &eacute;crire
   <LongDescription>Il y a apparemment une boucle infinie dans {1}</LongDescription>
   <Details>
 <![CDATA[
-<p>Cette boucle ne semble pas avoir un moyen de se terminer (autrement que, peut &ecirc;tre, en d&eacute;clenchant une exception).</p>
+<p>Cette boucle ne semble pas avoir un moyen de se terminer (autrement que, peut &ecirc;tre, en d&eacute;clenchant une exception). Les boucles sans condition comme <code>while (true) {...}</code> sont consider&eacute;es comme intentionnelles et ne sont pas report&eacute;es comme des bugs</p>
 ]]>
   </Details>
  </BugPattern>
diff --git a/spotbugsTestCases/src/java/infiniteLoop/Issue3460.java b/spotbugsTestCases/src/java/infiniteLoop/Issue3460.java
@@ -0,0 +1,12 @@
+package infiniteLoop;
+
+public class Issue3460 {
+
+    public void loop() {
+    	int counter = 0;
+    	while (true) {
+    		System.out.println("Counter: " + counter);
+    		counter++;
+    	}
+    }
+}
