fix: include nested exception details in error messages.

As part of springboot 3.0 upgrade, Spring Framework 6 changed how NestedRuntimeException (and subclasses like ResourceAccessException) format their messages, omitting the nested exception details in getMessage(). This change explicitly appends those details to provide better context in case of failures.
spinnaker · dbyron-sf · Nov 10, 2025 · Dec 3, 2024 · Dec 6, 2024 · Dec 11, 2024
commit 0945a3a972e03c941aaedd00475eea415a0392ca
diff --git a/...hook/src/main/java/com/netflix/spinnaker/orca/webhook/tasks/WebhookResponseProcessor.java b/...hook/src/main/java/com/netflix/spinnaker/orca/webhook/tasks/WebhookResponseProcessor.java
@@ -155,7 +155,10 @@ private TaskResult processClientException(RestTemplateData restTemplateData, Exc
       errorMessage =
           format(
               "An exception occurred for pipeline %s performing a %s request to %s. %s",
-              executionId, stageData.method, stageData.url, e.toString());
+              executionId, stageData.method, stageData.url, e);
+      if (e.getCause() != null) {
+        errorMessage = errorMessage + "; nested exception is " + e.getCause();
+      }
       executionStatus = ExecutionStatus.TERMINAL;
     }
     var webhookOutput = new WebhookStage.WebhookResponseStageData();

diff --git a/...ook/src/test/groovy/com/netflix/spinnaker/orca/webhook/tasks/CreateWebhookTaskSpec.groovy b/...ook/src/test/groovy/com/netflix/spinnaker/orca/webhook/tasks/CreateWebhookTaskSpec.groovy
@@ -256,7 +256,7 @@ class CreateWebhookTaskSpec extends Specification {
       expectedErrorMessage = "Socket timeout in webhook on POST request for pipeline ${stage.execution.id} to ${stage.context.url}, will retry."
     } else {
       expectedStatus = ExecutionStatus.TERMINAL
-      expectedErrorMessage = "An exception occurred for pipeline ${stage.execution.id} performing a POST request to ${stage.context.url}. org.springframework.web.client.ResourceAccessException: I/O error on POST request for https://my-service.io/api/"
+      expectedErrorMessage = "An exception occurred for pipeline ${stage.execution.id} performing a POST request to ${stage.context.url}. org.springframework.web.client.ResourceAccessException: I/O error on POST request for https://my-service.io/api/; nested exception is java.net.SocketTimeoutException: timeout"
     }
 
     result.status == expectedStatus