fix(web): return 405 for GET /api/mcp instead of hanging connection#1064
Merged
brendan-kellam merged 2 commits intomainfrom Mar 31, 2026
Merged
fix(web): return 405 for GET /api/mcp instead of hanging connection#1064brendan-kellam merged 2 commits intomainfrom
brendan-kellam merged 2 commits intomainfrom
Conversation
The GET SSE stream is only used for server-initiated messages, which Sourcebot does not send. Per the MCP Streamable HTTP spec, servers that do not offer a GET SSE stream MUST return 405 Method Not Allowed. Previously the handler opened an SSE stream that never flushed its HTTP headers, causing clients to hang until timeout. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This comment has been minimized.
This comment has been minimized.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe changes fix a bug where Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/mcphandler opened an SSE stream that never flushed its HTTP response headers, causing clients to hang until timeout (0 bytes received)405 Method Not AllowedFixes #1061
🤖 Generated with Claude Code
Summary by CodeRabbit
405 Method Not Allowedresponse per the MCP Streamable HTTP specification.