Add EstimatedTableRowsCount to avoid count in large tables#366
Merged
sosedoff merged 5 commits intososedoff:masterfrom Jun 18, 2018
allisson:master
Merged
Add EstimatedTableRowsCount to avoid count in large tables#366sosedoff merged 5 commits intososedoff:masterfrom allisson:master
sosedoff merged 5 commits intososedoff:masterfrom
allisson:master
Conversation
|
Can you provide some tests? |
Contributor
Author
|
@wiliamsouza |
Owner
|
Looks good, i'd add a test to verify |
Contributor
Author
|
@sosedoff sounds good. |
Contributor
Author
|
@sosedoff Take a look at the tests |
Owner
|
Tests look good. I think you forgot to include schema name in the estimated row count sql query. |
Contributor
Author
|
@sosedoff done 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #168