-
Notifications
You must be signed in to change notification settings - Fork 541
Change CXX standard using property #1666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I do not like it :-( https://github.com/ruevs/solvespace/actions/runs/20667998716 Update: it failed :-( Off... I really did not want to setup Emscripten on this system... I guess I'll have to... tomorrow... |
|
Here is what the LLM says... DetailsAnd all the places trying to set the standard: DetailsPerhaps we should go with your way, but at least put it in |
|
Off I'm too sleepy; you did put it in the Edit: and it worked! |
|
@vespakoen @phkahler I also fixed the failing WASM library compilation here d14609f The build now works: https://github.com/solvespace/solvespace/actions/runs/20681760812 I have no clue what to do about it. |
@phkahler @ruevs This worked on my fork, don't ask me why the first attempt didn't work, I don't feel like looking into it too deep.
The last attempt (using CMAKE_CXX_STANDARD) on my machine, also stopped working after clearing my cache, so I guess either
emcmakeignores theCMAKE_CXX_STANDARDsomehow, or maybeEMSCRIPTENisn't set for the web build?Please let me know if you are fine with this or just merge it ;)