Skip to content

Commit 9be8041

Browse files
author
notactuallyfinn
committed
removed tests of unclear matters (@type and @context fields) and added fixme
1 parent 1721325 commit 9be8041

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

test/hermes_test/model/test_api.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,6 @@ def test_append():
7171

7272
def test_iterative_assignment():
7373
# This tests iterative assignments/traversals to edit/appending values
74-
# This requires SoftwareMetadata.__getitem__ to return a plain dict. SoftwareMetadata.__setitem__ can then
75-
# implement the isinstanceof checks that @notactuallyfinn suggested.
7674
data = SoftwareMetadata(extra_vocabs={"foo": "https://foo.bar"})
7775
data["author"] = {"name": "Foo"}
7876
# Look, a squirrel!
@@ -125,11 +123,10 @@ def test_usage():
125123
assert baz["affiliation"].to_python() == ["Lab E"]
126124
assert len(baz["schema:knowsAbout"]) == 0
127125
assert len(baz["email"]) == 0
128-
assert data["@type"] == "SoftwareSourceCode"
129-
assert data["@context"] == ALL_CONTEXTS # FIXME: #435 will solve this issue
130126
for author in data["author"]:
131127
assert "name" in author
132128
assert "email" in author
133129
if "schema:knowsAbout" not in author:
130+
# FIXME: None has to be discussed
134131
author["schema:knowsAbout"] = None
135132
author["schema:pronouns"] = "they/them"

0 commit comments

Comments
 (0)