block/volume-detail: add iops details for endurance storage#854
block/volume-detail: add iops details for endurance storage#854houstar wants to merge 1 commit intosoftlayer:masterfrom
Conversation
allmightyspiff
left a comment
There was a problem hiding this comment.
http://sldn.softlayer.com/reference/datatypes/SoftLayer_Network_Storage has the "provisionedIops" property, which I would recommend using here instead of the properties. This way you can make the same change to file and block storage details and it should work for both.
|
Also, update the unit tests so they pass Travis CI. You can likely just change the test to not check for the mask as I don't think thats a very good test. |
|
@allmightyspiff Could you help me to skip the mask check ? |
|
The current test is tests/managers/block_tests.py I'd either update the mask to match what you changed it to, or just remove the mask along with the "mask='mask[%s]' % expected_mask" bit on self.assert_called_with. To test locally, you can use "tox" to run the test suite to make sure it all works. |
v1 -> v2: 1. use provisionedIops instead of properties. 2. updated mask accordingly. Signed-off-by: Leno Hou <[email protected]>
|
I'm going to address this in #912 |
Signed-off-by: Leno Hou [email protected]