Use expanduser() to find netrc file

sloria · sloria · commit d923e8d26cfa · 2018-01-12T10:12:03.000-06:00
Avoids an exception when $HOME is not set. This behavior matches the behavior in Python 3.7 See python/cpython#4537 close #2
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -1,6 +1,11 @@
 Changelog
 =========
 
+1.2.0 (unreleased)
+------------------
+
+* Don't error if ``$HOME`` is not set `#2 <https://github.com/sloria/tinynetrc/issues/2>`_.
+
 1.1.0 (2017-11-04)
 ------------------
 
diff --git a/tests/.netrc b/tests/.netrc
diff --git a/tests/test_tinynetrc.py b/tests/test_tinynetrc.py
@@ -7,7 +7,22 @@
 
 @pytest.fixture()
 def netrc():
-    return tinynetrc.Netrc(os.path.join(HERE, 'netrc_valid'))
+    return tinynetrc.Netrc(os.path.join(HERE, '.netrc'))
+
+
+def test_file_not_found():
+    with pytest.raises(IOError):
+        tinynetrc.Netrc('notfound')
+
+
+def test_home_unset(monkeypatch):
+    # Make "~" == the current directory
+    monkeypatch.setattr(os.path, 'expanduser', lambda path: HERE)
+    # Unset $HOME
+    monkeypatch.delenv('HOME', raising=False)
+    # No error
+    result = tinynetrc.Netrc()
+    assert 'mail.google.com' in result.hosts
 
 
 def test_hosts(netrc):
diff --git a/tinynetrc.py b/tinynetrc.py
@@ -34,10 +34,7 @@ class Netrc(MutableMapping):
 
     def __init__(self, file=None):
         if file is None:
-            try:
-                file = os.path.join(os.environ['HOME'], ".netrc")
-            except KeyError:
-                raise OSError("Could not find .netrc: $HOME is not set")
+            file = os.path.join(os.path.expanduser('~'), '.netrc')
         self.file = file
         self._netrc = netrc.netrc(file)
         self.machines = dictify_hosts(self._netrc.hosts)
