docs: include packaging script steps in the maintainers guide#1672
Merged
docs: include packaging script steps in the maintainers guide#1672
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1672 +/- ##
=======================================
Coverage 85.36% 85.36%
=======================================
Files 113 113
Lines 12802 12802
=======================================
Hits 10928 10928
Misses 1874 1874 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WilliamBergamin
approved these changes
Mar 13, 2025
Contributor
WilliamBergamin
left a comment
WilliamBergamin
left a comment
There was a problem hiding this comment.
Good catch 💯 sometimes knowing things lets them slip through 😢
Left one small suggestion on something I learn today
Co-authored-by: William Bergamin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR copies the steps for using
scripts/build_pypi_package.shfromslack_bolt- reference - to thismaintainers_guide.mdfor fast reference 📚Testing
The updated steps were used to test that the build script packages the
.whl!Category
/docs(Documents)maintainers_guide.mdRequirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.