Skip to content
This repository was archived by the owner on May 27, 2025. It is now read-only.
This repository was archived by the owner on May 27, 2025. It is now read-only.

RTM message format has changed, verify eventWrapper assumptions #589

@aoberoi

Description

@aoberoi

Description

We've noticed some changes in the RTM message format but have not actively updated the processing of each event in eventWrapper accordingly. It's possible that some of the assumptions made are no longer valid. That was the case in #586 - since bot_message events started having a user property the logic behind when to update the botUserIdMap was no longer correct.

A few more things to check:

  • Do we still need a botUserIdMap? I think yes, because the user ID of the bot is not enough information to put in the message.user object, otherwise there will be breaking changes. However, we also see a bot_profile on some (maybe all) events now - is that enough?
  • What happened to the subtype: 'bot_message'? It seems to be missing on at least some, but maybe all, events where it should be.
  • Is there a new property that can be used to know that a message was sent from Slackbot?

This is not an exhaustive list, and we should look for more changes we may need to make to eventWrapper.

Related to #588

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementM-T: A feature request for new functionality

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions