Skip to content

Improve Attribute View Layout - #15178

Draft
TCOTC wants to merge 4 commits into
siyuan-note:devfrom
TCOTC:fix/15093
Draft

Improve Attribute View Layout#15178
TCOTC wants to merge 4 commits into
siyuan-note:devfrom
TCOTC:fix/15093

Conversation

@TCOTC

@TCOTC TCOTC commented Jun 29, 2025

Copy link
Copy Markdown
Contributor

Note

这个 PR 的内容已经过时了,等我有空的时候把需要修改的部分重新整理出来

fix #15093 #15158

Comment thread app/src/assets/scss/business/_av.scss Outdated
&:empty::after {
color: var(--b3-theme-on-surface-light);
content: attr(data-tip);
pointer-events: none;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

伪元素影响了光标样式

image

content: attr(data-tip);
color: var(--b3-theme-on-surface-light);
cursor: text;
pointer-events: none;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

跟前面伪元素影响光标样式的问题使用一致的解决方法

Comment thread app/src/assets/scss/business/_av.scss
font-size: 85%;
min-height: 23px;
padding: 5px 4px;
padding: 10px 5px;

@TCOTC TCOTC Jun 29, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前的边距太窄了,有点难看,参考 Notion 把整体边距改到 10px

Comment thread app/src/assets/scss/protyle/_wysiwyg.scss Outdated
Comment thread app/src/protyle/render/av/gallery/render.ts Outdated
}

.av__cellassetimg {
margin: 3px 6px 3px 0;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

解决 单选、多选、资源字段 的边距问题

Vanessa219 added a commit that referenced this pull request Jun 30, 2025
@TCOTC

TCOTC commented Jun 30, 2025

Copy link
Copy Markdown
Contributor Author

3f65251

试了一下这个新加的逻辑不能解决问题

我的这个方法应该是 ok 的了:6e7c862 (#15178)

@Vanessa219

Copy link
Copy Markdown
Member

这样算解决没?我理解的是 box-shadow 提前消失的问题
https://github.com/user-attachments/assets/c3630723-9c49-4198-8ae7-c154152bb77b

@TCOTC

TCOTC commented Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

不只是 box-shadow 的问题,前面 #15178 (comment) 我提到了两个问题

我改成用 .av__container.fn__block { overflow: visible; } 应该是能完美解决的了

@Vanessa219

Vanessa219 commented Jul 1, 2025

Copy link
Copy Markdown
Member

哦,我修改的是切换时两侧的 box-shadow 会消失这个问题。你这个是可以的,这 pr 内容比较多,我先修改这个点。

Vanessa219 added a commit that referenced this pull request Jul 1, 2025
@TCOTC
TCOTC marked this pull request as draft January 12, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants