fix(normalization): update allowed integrations checks to be fully lowercase#3248
Merged
waleedlatif1 merged 1 commit intostagingfrom Feb 18, 2026
Merged
fix(normalization): update allowed integrations checks to be fully lowercase#3248waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR adds case normalization (
Both changes are defensive — block types from the registry and env allowlist values are already lowercase in practice — but they close a gap where mixed-case values from permission group configs could slip through unmatched.
Confidence Score: 4/5
Important Files Changed
Flowchartflowchart TD
A["intersectAllowlists(a, b)"] --> B{"a === null?"}
B -->|Yes| C["Return b (env allowlist, already lowercase)"]
B -->|No| D{"b === null?"}
D -->|Yes| E["Return a.map(toLowerCase) ✅ NEW"]
D -->|No| F["Return a.map(toLowerCase).filter(i => b.includes(i))"]
G["integrations.tsx groupedServices"] --> H["service.id.replace(/-/g, '_').toLowerCase() ✅ NEW"]
H --> I{"permissionConfig.allowedIntegrations.includes(normalized)?"}
I -->|Yes| J["Include service in UI"]
I -->|No| K["Filter out service"]
Last reviewed commit: 35b1d7e |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
46
to
48
| if (a === null) return b | ||
| if (b === null) return a | ||
| if (b === null) return a.map((i) => i.toLowerCase()) | ||
| return a.map((i) => i.toLowerCase()).filter((i) => b.includes(i)) |
Contributor
There was a problem hiding this comment.
Inconsistent lowercasing across branches
When a === null, b is returned as-is (line 46), but when b === null, a is now lowercased (line 47). On line 48, a is lowercased but b is not lowercased before filtering. While this currently works because b (the env allowlist) is already lowercase from getAllowedIntegrationsFromEnv(), the asymmetry makes the function fragile — if b ever comes from a source that isn't pre-lowercased, the intersection on line 48 would silently drop valid entries.
Consider normalizing both inputs uniformly:
Suggested change
| if (a === null) return b | |
| if (b === null) return a | |
| if (b === null) return a.map((i) => i.toLowerCase()) | |
| return a.map((i) => i.toLowerCase()).filter((i) => b.includes(i)) | |
| if (a === null) return b?.map((i) => i.toLowerCase()) ?? null | |
| if (b === null) return a.map((i) => i.toLowerCase()) | |
| return a.map((i) => i.toLowerCase()).filter((i) => b.map((j) => j.toLowerCase()).includes(i)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist