fix(lock): prevent socket crash when locking agent blocks#3245
Merged
waleedlatif1 merged 1 commit intostagingfrom Feb 18, 2026
Merged
fix(lock): prevent socket crash when locking agent blocks#3245waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryFixes a bug where editing subblocks on locked agent blocks caused the socket to enter offline mode. The root cause was that
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client as Client (Browser)
participant Socket as Socket Server
participant DB as Database
Client->>Socket: subblock-update (locked block)
Socket->>DB: BEGIN transaction
DB-->>Socket: block.locked = true
Note over Socket: Sets blockLocked = true, returns early
Socket->>DB: ROLLBACK (no changes)
alt Before fix
Socket->>Client: operation-failed (retryable: false)
Note over Client: triggerOfflineMode() → socket crashes
else After fix
Socket->>Client: operation-confirmed
Note over Client: Operation acknowledged, no offline mode
end
Last reviewed commit: 964fda9 |
...sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/editor.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist