Skip to content

feat(pipedrive): added sort order to endpoints that support it, upgraded turborepo#3237

Merged
waleedlatif1 merged 3 commits intostagingfrom
fix/too
Feb 17, 2026
Merged

feat(pipedrive): added sort order to endpoints that support it, upgraded turborepo#3237
waleedlatif1 merged 3 commits intostagingfrom
fix/too

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • added sort order to endpoints that support it
  • upgraded turborepo

Type of Change

  • New feature

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Feb 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Feb 17, 2026 10:57pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 17, 2026

Greptile Summary

This PR adds sorting functionality to the Pipedrive get_files endpoint and upgrades turborepo from 2.8.3 to 2.8.9. The sort parameter allows users to order files by id or update_time, with the implementation spanning the UI layer (blocks), tool configuration, API route, and TypeScript type definitions.

Key Changes:

  • Added sort parameter to get_files endpoint with support for id and update_time sorting
  • Updated UI to include a sort dropdown with two options
  • Modified API route to accept and forward sort parameter to Pipedrive API
  • Updated documentation to reflect the new parameter
  • Upgraded turbo dependency (minor version bump from 2.8.3 to 2.8.9)

Issues Found:

  • The API route accepts any string value for the sort parameter without validation, which could cause runtime errors if invalid values are passed to the Pipedrive API

Confidence Score: 4/5

  • This PR is generally safe to merge with one validation issue that should be addressed
  • The implementation is straightforward and follows existing patterns in the codebase. However, the lack of validation on the sort parameter in the API route could allow invalid values to be passed to the Pipedrive API, potentially causing runtime errors. The turborepo upgrade is a minor version bump with no breaking changes expected.
  • apps/sim/app/api/tools/pipedrive/get-files/route.ts needs validation added for the sort parameter

Important Files Changed

Filename Overview
apps/sim/app/api/tools/pipedrive/get-files/route.ts Added sort parameter to the schema and query params with basic string validation
apps/sim/tools/pipedrive/get_files.ts Added sort parameter definition to tool config with proper description
apps/sim/tools/pipedrive/types.ts Added optional sort field to PipedriveGetFilesParams interface
apps/sim/blocks/blocks/pipedrive.ts Added sort dropdown UI field with id and update_time options

Flowchart

flowchart TD
    A[User selects sort option in UI] --> B[Block config: pipedrive.ts]
    B --> C[Tool config: get_files.ts]
    C --> D[API Route: get-files/route.ts]
    D --> E{Validate with Zod schema}
    E --> F[Build query params]
    F --> G[Append sort to URLSearchParams]
    G --> H[Call Pipedrive API]
    H --> I[Return sorted files]
    
    style E fill:#f9f,stroke:#333,stroke-width:2px
    style D fill:#bbf,stroke:#333,stroke-width:2px
Loading

Last reviewed commit: 3958dd7

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@waleedlatif1 waleedlatif1 merged commit a0afb5d into staging Feb 17, 2026
6 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/too branch February 18, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments