Skip to content

fix(teams): webhook notifications crash #2426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 33 commits into from
Dec 18, 2025
Merged

fix(teams): webhook notifications crash #2426

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
8f0ef58
v0.5.7: combobox selectors, usage indicator, workflow loading race co…
icecrasher321 Nov 18, 2025
31c34b2
v0.5.8: notifications, billing, ui changes, store loading state machine
icecrasher321 Nov 20, 2025
842ef27
v0.5.9: add backwards compatibility for agent messages array
waleedlatif1 Nov 20, 2025
b7e814b
v0.5.10: copilot upgrade, preprocessor, logs search, UI, code hygiene
waleedlatif1 Nov 21, 2025
ebcd243
v0.5.11: stt, videogen, vllm, billing fixes, new models
waleedlatif1 Nov 25, 2025
1d08796
v0.5.12: memory optimizations, sentry, incidentio, posthog, zendesk, …
waleedlatif1 Nov 29, 2025
8c32ad4
v0.5.13: polling fixes, generic agent search tool, status page, smtp,…
waleedlatif1 Dec 1, 2025
54cc937
v0.5.14: fix issue with teams, google selectors + cleanup code
icecrasher321 Dec 1, 2025
774e5d5
v0.5.15: add tools, revert subblock prop change
icecrasher321 Dec 1, 2025
e157ce5
v0.5.16: MCP fixes, code refactors, jira fixes, new mistral models
waleedlatif1 Dec 3, 2025
3187493
v0.5.17: modals, billing fixes, bun update, zoom, dropbox, kalshi, po…
waleedlatif1 Dec 4, 2025
6cd078b
v0.5.18: ui fixes, nextjs16, workspace notifications, admin APIs, loa…
icecrasher321 Dec 5, 2025
929a352
fix(build): added trigger.dev sdk mock to tests (#2216)
icecrasher321 Dec 5, 2025
12c4c2d
v0.5.19: copilot fix
icecrasher321 Dec 5, 2025
ebef5f3
v0.5.20: google slides, ui fixes, subflow resizing improvements
waleedlatif1 Dec 6, 2025
c27c233
v0.5.21: google groups, virtualized code viewer, ui, autolayout, docs…
waleedlatif1 Dec 8, 2025
d480057
fix(migration): migration got removed by force push (#2253)
icecrasher321 Dec 8, 2025
52edbea
v0.5.22: rss feed trigger, sftp tool, billing fixes, 413 surfacing, c…
waleedlatif1 Dec 9, 2025
b7bbef8
v0.5.23: kb, logs, general ui improvements, token bucket rate limits,…
waleedlatif1 Dec 10, 2025
18b7032
v0.5.24: agent tool and UX improvements, redis service overhaul (#2291)
waleedlatif1 Dec 10, 2025
b5da613
v0.5.25: minor ui improvements, copilot billing fix
icecrasher321 Dec 11, 2025
3fbd57c
v0.5.26: tool fixes, templates and knowledgebase fixes, deployment ve…
waleedlatif1 Dec 11, 2025
e24f31c
v0.5.27: sidebar updates, ssrf patches, gpt-5.2, stagehand fixes
waleedlatif1 Dec 11, 2025
f526c36
v0.5.28: tool fixes, sqs, spotify, nextjs update, component playground
waleedlatif1 Dec 13, 2025
a0fb889
v0.5.29: chat voice mode, opengraph for docs, option to disable auth
waleedlatif1 Dec 14, 2025
842200b
fix(docs): clarify working directory for drizzle migration (#2375)
Shivam-002 Dec 15, 2025
fcf52ac
fix(landing): prevent url encoding for spaces for footer links (#2376)
Chadha93 Dec 15, 2025
25afacb
v0.5.30: vllm fixes, permissions fixes, isolated vms for code executi…
waleedlatif1 Dec 16, 2025
f9cfca9
v0.5.31: add zod as direct dep
icecrasher321 Dec 16, 2025
837aabc
v0.5.32: google sheets fix, schedule input format
waleedlatif1 Dec 16, 2025
7052c76
fix: handle empty body.value in Teams webhook notification parser (#2…
Dec 17, 2025
088a086
Merge branch 'main' of https://github.com/CodeLoopdroid/sim into fix/…
CodeLoopdroid Dec 17, 2025
9b1be0a
Update directory path for migration command
CodeLoopdroid Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update directory path for migration command
  • Loading branch information
@CodeLoopdroid
CodeLoopdroid authored Dec 17, 2025
commit 9b1be0af088971d70b9255e5fec1db9643e2d8d3
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Copy link
Collaborator

@icecrasher321 icecrasher321 Dec 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CodeLoopdroid you should be in packages/db not apps/sim?

Copy link
Contributor Author

@CodeLoopdroid CodeLoopdroid Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!
Just to clarify, are you suggesting that the Teams webhook parsing logic should be moved into packages/db and then imported into apps/sim, or is the current fix in apps/sim acceptable for now?

Copy link
Collaborator

@icecrasher321 icecrasher321 Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was referring to you adding the comment in the readme -- for running bunx drizzle-kit migrate you should be inside packages/db

Copy link
Contributor Author

@CodeLoopdroid CodeLoopdroid Dec 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification, @icecrasher321
I’ve updated the README file to reflect the correct working directory for running migrations.

Copy link
Contributor Author

@CodeLoopdroid CodeLoopdroid Dec 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @waleedlatif1
Could you approve the pending workflow / Vercel auth when you have time?
Thanks

Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ DATABASE_URL="postgresql://postgres:your_password@localhost:5432/simstudio"

Then run the migrations:
```bash
cd apps/sim # Required so drizzle picks correct .env file
cd packages/db # Required so drizzle picks correct .env file
bunx drizzle-kit migrate --config=./drizzle.config.ts
```

Expand Down