fix: prevent URL encoding for spaces#2376
Merged
waleedlatif1 merged 1 commit intosimstudioai:mainfrom Dec 15, 2025
Merged
Conversation
Signed-off-by: Gaurav Chadha <[email protected]>
|
@Chadha93 is attempting to deploy a commit to the Sim Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile OverviewGreptile SummaryFixed URL generation for multi-word block names in the footer component.
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant Footer
participant BlockLink
participant DocsURL
User->>Footer: Renders footer component
Footer->>BlockLink: Maps FOOTER_BLOCKS array
BlockLink->>BlockLink: block.toLowerCase()
BlockLink->>BlockLink: replaceAll(' ', '-')
Note right of BlockLink: "Human In The Loop" → "human-in-the-loop"
BlockLink->>DocsURL: Generate URL
DocsURL-->>User: https://docs.sim.ai/blocks/human-in-the-loop
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
waleedlatif1
pushed a commit
that referenced
this pull request
Dec 18, 2025
icecrasher321
added a commit
that referenced
this pull request
Dec 18, 2025
* fix(docs): clarify working directory for drizzle migration (#2375) * fix(landing): prevent url encoding for spaces for footer links (#2376) * fix: handle empty body.value in Teams webhook notification parser (#2425) * Update directory path for migration command --------- Co-authored-by: Vikhyath Mondreti <[email protected]> Co-authored-by: Waleed <[email protected]> Co-authored-by: waleedlatif1 <[email protected]> Co-authored-by: icecrasher321 <[email protected]> Co-authored-by: Siddharth Ganesan <[email protected]> Co-authored-by: mosa <[email protected]> Co-authored-by: Emir Karabeg <[email protected]> Co-authored-by: Adam Gough <[email protected]> Co-authored-by: Shivam <[email protected]> Co-authored-by: Gaurav Chadha <[email protected]> Co-authored-by: root <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brief description of what this PR does and why.
fix: use replaceAll for footer block URLs to handle multi-word names which fixes issue where "Human In The Loop" was generating
/blocks/human-in%20the%20loop instead of /blocks/human-in-the-loop
by replacing only the first space. Changed to replaceAll(' ', '-')
to handle all spaces correctly.
Fixes #(issue)
Type of Change
Testing
How has this been tested? What should reviewers focus on?
Click on Human In The Loop from site's footer block it will redirect to 404 - https://docs.sim.ai/blocks/human-in%20the%20loop
Checklist
Screenshots/Videos