fix(redis): cleanup access pattern across callsites#2289
Merged
waleedlatif1 merged 2 commits intostagingfrom Dec 10, 2025
Merged
fix(redis): cleanup access pattern across callsites#2289waleedlatif1 merged 2 commits intostagingfrom
waleedlatif1 merged 2 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryThis PR implements a comprehensive cleanup of Redis access patterns across the codebase to eliminate non-deterministic behavior and fix distributed locking issues. The main changes include:
The changes ensure predictable system behavior by making storage decisions at configuration time rather than runtime, improving reliability in distributed environments. Important Files Changed
Confidence score: 4/5
Sequence DiagramsequenceDiagram
participant User
participant NotificationPollAPI as "GET /api/notifications/poll"
participant CronAuth as "verifyCronAuth"
participant Redis as "Redis Lock Service"
participant InactivityPoller as "pollInactivityAlerts"
User->>NotificationPollAPI: "GET /api/notifications/poll"
NotificationPollAPI->>CronAuth: "verifyCronAuth(request)"
alt Auth Failed
CronAuth-->>NotificationPollAPI: "Return auth error"
NotificationPollAPI-->>User: "Return error response"
end
NotificationPollAPI->>Redis: "acquireLock(LOCK_KEY, requestId, 120)"
alt Lock Already Held
Redis-->>NotificationPollAPI: "false (lock not acquired)"
NotificationPollAPI-->>User: "Return 202 - Polling already in progress"
else Lock Acquired
Redis-->>NotificationPollAPI: "true (lock acquired)"
NotificationPollAPI->>InactivityPoller: "pollInactivityAlerts()"
InactivityPoller-->>NotificationPollAPI: "Return polling results"
NotificationPollAPI-->>User: "Return 200 - Polling completed"
end
NotificationPollAPI->>Redis: "releaseLock(LOCK_KEY, requestId)"
Redis-->>NotificationPollAPI: "Lock released"
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Collaborator
|
@greptile |
waleedlatif1
added a commit
that referenced
this pull request
Dec 10, 2025
* feat(folders): add the ability to create a folder within a folder in popover (#2287) * fix(agent): filter out empty params to ensure LLM can set tool params at runtime (#2288) * fix(mcp): added backfill effect to add missing descriptions for mcp tools (#2290) * fix(redis): cleanup access pattern across callsites (#2289) * fix(redis): cleanup access pattern across callsites * swap redis command to be non blocking * improvement(log-details): polling, trace spans (#2292) --------- Co-authored-by: Vikhyath Mondreti <[email protected]> Co-authored-by: Emir Karabeg <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup access pattern across codebase for redis client.
Type of Change
Testing
Tested with @waleedlatif1
Checklist