fix(agent): filter out empty params to ensure LLM can set tool params at runtime#2288
Merged
waleedlatif1 merged 1 commit intostagingfrom Dec 10, 2025
Merged
fix(agent): filter out empty params to ensure LLM can set tool params at runtime#2288waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryFixes a bug where user-cleared form fields (empty strings
The fix is consistent with the existing Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant UI as User Interface
participant State as UI State
participant PrepTool as prepareToolExecution
participant MergeTool as mergeToolParameters
participant LLM as LLM Agent
UI->>State: User sets field value
UI->>State: User clears field (becomes '')
State->>PrepTool: tool.params (includes '')
LLM->>PrepTool: llmArgs (generated values)
PrepTool->>PrepTool: Filter out empty/null/undefined
PrepTool->>PrepTool: Merge filtered params with llmArgs
Note over PrepTool: LLM values preserved for cleared fields
alt Custom Tool Path
State->>MergeTool: userProvidedParams (includes '')
LLM->>MergeTool: callParams (generated values)
MergeTool->>MergeTool: Filter out empty/null/undefined
MergeTool->>MergeTool: Merge filtered params with callParams
Note over MergeTool: LLM values preserved for cleared fields
end
|
waleedlatif1
added a commit
that referenced
this pull request
Dec 10, 2025
* feat(folders): add the ability to create a folder within a folder in popover (#2287) * fix(agent): filter out empty params to ensure LLM can set tool params at runtime (#2288) * fix(mcp): added backfill effect to add missing descriptions for mcp tools (#2290) * fix(redis): cleanup access pattern across callsites (#2289) * fix(redis): cleanup access pattern across callsites * swap redis command to be non blocking * improvement(log-details): polling, trace spans (#2292) --------- Co-authored-by: Vikhyath Mondreti <[email protected]> Co-authored-by: Emir Karabeg <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist