Skip to content

fix(deps): declare core transient deps explicitly#2147

Merged
waleedlatif1 merged 2 commits intostagingfrom
fix/dependencies
Dec 1, 2025
Merged

fix(deps): declare core transient deps explicitly#2147
waleedlatif1 merged 2 commits intostagingfrom
fix/dependencies

Conversation

@waleedlatif1
Copy link
Collaborator

@waleedlatif1 waleedlatif1 commented Dec 1, 2025

Summary

  • declare core transient deps explicitly, some of them are core deps that were missing but it worked because of hoisting

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Dec 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Dec 1, 2025 5:49pm

@waleedlatif1 waleedlatif1 marked this pull request as ready for review December 1, 2025 17:39
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 1, 2025

Greptile Overview

Greptile Summary

Explicitly declares 8 transient dependencies that were previously only available through hoisting: @opentelemetry/sdk-trace-base, @opentelemetry/sdk-trace-node, @radix-ui/react-visually-hidden, @react-email/render, chalk, lodash, and zustand.

  • Verified all newly declared dependencies are actively used in the codebase
  • chalk usage confirmed in lib/logs/console/logger.ts:7
  • lodash (specifically cloneDeep) used in workflow-preview.tsx:4
  • zustand extensively used across 31+ store files
  • @radix-ui/react-visually-hidden used in search and settings modals
  • @react-email/render used for email rendering in workspace invitations
  • OpenTelemetry packages used in instrumentation configuration

Critical Issue Found:

Confidence Score: 2/5

  • This PR has a critical version mismatch that could cause runtime issues with OpenTelemetry instrumentation
  • The intent to declare transient dependencies is correct and necessary, but the OpenTelemetry version mismatch (declaring 2.2.0 when [email protected] expects 2.0.0) creates a dependency conflict that could cause runtime errors or undefined behavior in telemetry collection
  • The apps/sim/package.json file needs attention - specifically the OpenTelemetry sdk-trace-base and sdk-trace-node versions must be corrected from 2.2.0 to 2.0.0 to match the expectations of @opentelemetry/[email protected]

Important Files Changed

File Analysis

Filename Score Overview
apps/sim/package.json 4/5 Explicitly declares 8 transient dependencies (@opentelemetry/sdk-trace-*, @radix-ui/react-visually-hidden, @react-email/render, chalk, lodash, zustand) that were previously hoisted; OpenTelemetry version mismatch issue detected

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager (Bun)
    participant App as Application Code
    participant Deps as Dependencies

    Dev->>PM: Add explicit dependencies to package.json
    Note over Dev,PM: @opentelemetry/sdk-trace-base: 2.2.0<br/>@opentelemetry/sdk-trace-node: 2.2.0<br/>@radix-ui/react-visually-hidden: 1.2.4<br/>@react-email/render: 2.0.0<br/>chalk: 5.6.2<br/>lodash: 4.17.21<br/>zustand: ^4.5.7
    
    PM->>PM: Resolve dependency tree
    PM->>PM: Update bun.lock
    Note over PM: Version resolution:<br/>- OpenTelemetry packages updated to 2.2.0<br/>- chalk upgraded from 4.1.2 to 5.6.2<br/>- prettier upgraded to 3.6.2<br/>- Transitive deps properly resolved
    
    PM->>Deps: Install/Update packages
    
    App->>Deps: Import @opentelemetry/sdk-trace-base
    Note over App,Deps: instrumentation-node.ts:56
    App->>Deps: Import @opentelemetry/sdk-trace-node
    Note over App,Deps: instrumentation-node.ts:54
    
    App->>Deps: Import @radix-ui/react-visually-hidden
    Note over App,Deps: search-modal.tsx:5<br/>settings-modal.tsx
    
    App->>Deps: Import @react-email/render
    Note over App,Deps: invitations/route.ts:2
    
    App->>Deps: Import chalk
    Note over App,Deps: logger.ts:7
    
    App->>Deps: Import lodash
    Note over App,Deps: workflow-preview.tsx:4
    
    App->>Deps: Import zustand
    Note over App,Deps: 31+ store files
    
    Deps-->>App: Modules available
    
    Note over Dev,Deps: Issue: Version mismatch detected<br/>[email protected] expects 2.0.0<br/>but 2.2.0 declared explicitly
Loading

greptile-apps[bot]
greptile-apps bot reviewed Dec 1, 2025
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit 1e080e9 into staging Dec 1, 2025
9 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/dependencies branch December 1, 2025 17:51
@waleedlatif1 waleedlatif1 mentioned this pull request Dec 1, 2025
Merged
waleedlatif1 added a commit that referenced this pull request Dec 1, 2025
@waleedlatif1 @icecrasher321
v0.5.13: polling fixes, generic agent search tool, status page, smtp,…
8c32ad4 
… sendgrid, linkedin, more tools (#2148)

* feat(tools): added smtp, sendgrid, mailgun, linkedin, fixed permissions in context menu (#2133)

* feat(tools): added twilio sendgrid integration

* feat(tools): added smtp, sendgrid, mailgun, fixed permissions in context menu

* added top level mocks for sporadically failing tests

* incr type safety

* fix(team-plans): track departed member usage so value not lost (#2118)

* fix(team-plans): track departed member usage so value not lost

* reset usage to 0 when they leave team

* prep merge with stagig

* regen migrations

* fix org invite + ws selection'

---------

Co-authored-by: Waleed <[email protected]>

* feat(i18n): update translations (#2134)

Co-authored-by: waleedlatif1 <[email protected]>

* feat(creators): add verification for creators (#2135)

* feat(tools): added apify block/tools  (#2136)

* feat(tools): added apify

* cleanup

* feat(i18n): update translations (#2137)

Co-authored-by: waleedlatif1 <[email protected]>

* feat(env): added more optional env var examples (#2138)

* feat(statuspage): added statuspage, updated list of tools in footer, renamed routes (#2139)

* feat(statuspage): added statuspage, updated list of tools in footer, renamed routes

* ack PR comments

* feat(tools): add generic search tool (#2140)

* feat(i18n): update translations (#2141)

* fix(sdks): bump sdk versions (#2142)

* fix(webhooks): count test webhooks towards usage limit (#2143)

* fix(bill): add requestId to webhook processing (#2144)

* improvement(subflow): remove all associated edges when moving a block into a subflow (#2145)

* improvement(subflow): remove all associated edges when moving a block into a subflow

* ack PR comments

* fix(polling): mark webhook failed on webhook trigger errors (#2146)

* fix(deps): declare core transient deps explicitly (#2147)

* fix(deps): declare core transient deps explicitly

* ack PR comments

---------

Co-authored-by: Vikhyath Mondreti <[email protected]>
Co-authored-by: waleedlatif1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1

Comments