improvement(subflow): remove all associated edges when moving a block into a subflow#2145
Merged
waleedlatif1 merged 2 commits intostagingfrom Dec 1, 2025
Merged
improvement(subflow): remove all associated edges when moving a block into a subflow#2145waleedlatif1 merged 2 commits intostagingfrom
waleedlatif1 merged 2 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryThis PR improves subflow edge management by ensuring all connected edges are removed when moving a block into a subflow container, matching the existing behavior when removing blocks from subflows. Key Changes:
The implementation properly handles undo/redo by batching edge operations with the parent update event, preventing individual edge recordings that would clutter the history. Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant Workflow
participant removeEdgesForNode
participant updateNodeParent
participant UndoRedo
alt Moving Block INTO Subflow
User->>Workflow: Drag block into subflow container
Workflow->>Workflow: Filter edges connected to block
Workflow->>removeEdgesForNode: removeEdgesForNode(blockId, edgesToRemove)
removeEdgesForNode->>removeEdgesForNode: Dispatch skip-edge-recording (true)
loop For each edge
removeEdgesForNode->>Workflow: removeEdge(edge.id)
end
removeEdgesForNode->>removeEdgesForNode: Dispatch skip-edge-recording (false)
Workflow->>Workflow: Compute auto-connect edges (edgesToAdd)
Workflow->>Workflow: Combine affectedEdges = [...edgesToRemove, ...edgesToAdd]
Workflow->>updateNodeParent: updateNodeParent(blockId, parentId, affectedEdges)
updateNodeParent->>UndoRedo: Record parent update with all affected edges
loop For each new edge
Workflow->>Workflow: addEdge(edge)
end
end
alt Moving Block OUT of Subflow
User->>Workflow: Trigger remove-from-subflow event
Workflow->>Workflow: Filter edges connected to block
Workflow->>removeEdgesForNode: removeEdgesForNode(blockId, edgesToRemove)
removeEdgesForNode->>removeEdgesForNode: Dispatch skip-edge-recording (true)
loop For each edge
removeEdgesForNode->>Workflow: removeEdge(edge.id)
end
removeEdgesForNode->>removeEdgesForNode: Dispatch skip-edge-recording (false)
Workflow->>updateNodeParent: updateNodeParent(blockId, null, edgesToRemove)
updateNodeParent->>UndoRedo: Record parent update with removed edges
end
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Additional Comments (1)
-
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx, line 2006-2020 (link)logic: Missing
removeEdgesForNodeandedgesForDisplayin dependency array
1 file reviewed, 1 comment
Collaborator
Author
|
@greptile |
waleedlatif1
added a commit
that referenced
this pull request
Dec 1, 2025
… sendgrid, linkedin, more tools (#2148) * feat(tools): added smtp, sendgrid, mailgun, linkedin, fixed permissions in context menu (#2133) * feat(tools): added twilio sendgrid integration * feat(tools): added smtp, sendgrid, mailgun, fixed permissions in context menu * added top level mocks for sporadically failing tests * incr type safety * fix(team-plans): track departed member usage so value not lost (#2118) * fix(team-plans): track departed member usage so value not lost * reset usage to 0 when they leave team * prep merge with stagig * regen migrations * fix org invite + ws selection' --------- Co-authored-by: Waleed <[email protected]> * feat(i18n): update translations (#2134) Co-authored-by: waleedlatif1 <[email protected]> * feat(creators): add verification for creators (#2135) * feat(tools): added apify block/tools (#2136) * feat(tools): added apify * cleanup * feat(i18n): update translations (#2137) Co-authored-by: waleedlatif1 <[email protected]> * feat(env): added more optional env var examples (#2138) * feat(statuspage): added statuspage, updated list of tools in footer, renamed routes (#2139) * feat(statuspage): added statuspage, updated list of tools in footer, renamed routes * ack PR comments * feat(tools): add generic search tool (#2140) * feat(i18n): update translations (#2141) * fix(sdks): bump sdk versions (#2142) * fix(webhooks): count test webhooks towards usage limit (#2143) * fix(bill): add requestId to webhook processing (#2144) * improvement(subflow): remove all associated edges when moving a block into a subflow (#2145) * improvement(subflow): remove all associated edges when moving a block into a subflow * ack PR comments * fix(polling): mark webhook failed on webhook trigger errors (#2146) * fix(deps): declare core transient deps explicitly (#2147) * fix(deps): declare core transient deps explicitly * ack PR comments --------- Co-authored-by: Vikhyath Mondreti <[email protected]> Co-authored-by: waleedlatif1 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist