Merged
Conversation
carlos-villavicencio-adsk
approved these changes
Aug 16, 2023
Contributor
carlos-villavicencio-adsk
left a comment
carlos-villavicencio-adsk
left a comment
There was a problem hiding this comment.
LGTM! Thank you for this 
|
|
||
| # FIXME: This should probably be refactored into a base class for | ||
| # all test bases | ||
| class TestBaseWithExceptionTests(unittest.TestCase): |
| if result['id'] == expected_id: | ||
| return True | ||
| return False | ||
| return any(result['id'] == expected_id for result in results) |
Contributor
There was a problem hiding this comment.
Good job on this one!
Contributor
|
Also, would you mind removing the Python 2 badge from the README.md file, please? |
minna-feng
added a commit
that referenced
this pull request
Aug 17, 2023
* remove references to py2 and skip tests * small fix * revert change * revert change * revert change * revert change * remove badge * use assertRaisesRegex
carlos-villavicencio-adsk
added a commit
that referenced
this pull request
Aug 28, 2023
* update certifi 2023.07.22 * update requirements.txt * SG-31340 Deprecation of Python 2 (#295) * remove references to py2 and skip tests * small fix * revert change * revert change * revert change * revert change * remove badge * use assertRaisesRegex * Empty commit --------- Co-authored-by: Carlos Villavicencio <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.