added radix sort to your sorts in src/sortingandsearching#47
Open
Yash-git98 wants to merge 1 commit intosherxon:masterfrom
Open
added radix sort to your sorts in src/sortingandsearching#47Yash-git98 wants to merge 1 commit intosherxon:masterfrom
Yash-git98 wants to merge 1 commit intosherxon:masterfrom
Conversation
sherxon
reviewed
Jan 21, 2019
| @@ -0,0 +1,59 @@ | |||
| package pers.jack.sort; | |||
| return MAX; | ||
| } | ||
|
|
||
| public static void COUNT_RAD(int arr[], int exp) { |
Owner
There was a problem hiding this comment.
pls follow java naming guide, wrong method naming here
| Print(arr); | ||
| } | ||
|
|
||
| public static int getMax(int arr[]) { |
Owner
There was a problem hiding this comment.
you dont have to make all methods static
| import java.util.*; | ||
|
|
||
|
|
||
| public class Radixsort { |
Owner
There was a problem hiding this comment.
you have different file name than class name
|
|
||
| public static void RADIXsort(int arr[]) { | ||
| int m = getMax(arr); | ||
| //////////////LEAST SIGNIFICANT/////////////////// |
Owner
There was a problem hiding this comment.
write notes/intentions/docs on top of method
| COUNT_RAD(arr, exp); | ||
| } | ||
|
|
||
| public static void Print(int arr[]) { |
Owner
There was a problem hiding this comment.
you can use Arrays.toString() method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please merge the code if you find it relevant
Please do not mark it as a spam.