the class that provides AVL tree delete method has been added#40
Open
bakhodir10 wants to merge 2 commits intosherxon:masterfrom
bakhodir10:master
Open
the class that provides AVL tree delete method has been added#40bakhodir10 wants to merge 2 commits intosherxon:masterfrom bakhodir10:master
bakhodir10 wants to merge 2 commits intosherxon:masterfrom
bakhodir10:master
Conversation
sherxon
reviewed
Feb 1, 2018
| return node == null ? -1 : node.height; | ||
| } | ||
|
|
||
| private int max(int a, int b) { |
Owner
There was a problem hiding this comment.
why didn't you use Math.max() instead of creating this method
Author
There was a problem hiding this comment.
Yes, I should have used Math.max() method. it would be less code ))
Owner
There was a problem hiding this comment.
@bakhodirsbox Did you test all cases? if it is passing i will merge and close this
Author
There was a problem hiding this comment.
@sherxon It looked correct after then I have found some errors, let me fix it. I think I can pull request after making sure it works correctly for every test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.