[CI] Consolidate Docker release workflows into reusable workflow#21596
Open
Kangyan-Zhou wants to merge 4 commits intosgl-project:mainfrom
Open
[CI] Consolidate Docker release workflows into reusable workflow#21596Kangyan-Zhou wants to merge 4 commits intosgl-project:mainfrom
Kangyan-Zhou wants to merge 4 commits intosgl-project:mainfrom
Conversation
Extract shared build logic (checkout, disk cleanup, buildx setup, Docker login, build-by-digest, manifest creation) into a reusable _docker-build- and-publish.yml workflow. The 3 remaining caller workflows are thin wrappers that specify target, version, tags, and environment. Changes: - New: _docker-build-and-publish.yml reusable workflow (workflow_call) - Simplified: release-docker.yml (295→47 lines) - Simplified: release-docker-runtime.yml (310→47 lines) - Simplified: release-docker-dev.yml (210→96 lines) - Deleted: release-docker-cu13-framework.yml (temporary, now redundant) Also fixes: runtime ARM64 CUDA 13 build was missing --build-arg INSTALL_FLASHINFER_JIT_CACHE=1 (now handled uniformly). Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Kangyan-Zhou
requested review from
Fridge003,
bingxche,
ispobock and
merrymercy
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Extract the nightly tag cleanup logic into _docker-cleanup-nightly.yml so it can be called from release-docker-dev.yml and also triggered manually via workflow_dispatch for on-demand cleanup. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
…ntime) Add aggressive_cleanup input (default false) to the reusable workflow. When false (release/runtime), free-disk-space uses conservative settings (tool-cache/docker-images/swap-storage: false) and Docker prune is skipped — matching the original behavior. When true (dev), aggressive cleanup is used. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
More disk space is always better on dedicated build nodes. No need to parameterize this. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_docker-build-and-publish.ymlworkflow (workflow_call)release-docker-cu13-framework.yml(self-described as temporary, now redundant withrelease-docker.yml)--build-arg INSTALL_FLASHINFER_JIT_CACHE=1upload-artifact/download-artifactfor passing digestsBefore → After
_docker-build-and-publish.ymlrelease-docker.ymlrelease-docker-runtime.ymlrelease-docker-dev.ymlrelease-docker-cu13-framework.ymlTest plan
Release Docker Imagesworkflow viaworkflow_dispatchand verify framework images build + manifests createdRelease Docker Runtime Imagesworkflow viaworkflow_dispatchand verify runtime images build + manifests createdBuild and Push Development Docker Imagesworkflow with a custom tag and verify dev images build correctlydev/dev-cu13/nightly-dev-*tags🤖 Generated with Claude Code