Skip to content

docs: fix broken image links on npm - #1342

Merged
eshanholtz merged 2 commits into
sendgrid:mainfrom
IObert:main
Mar 2, 2022
Merged

docs: fix broken image links on npm#1342
eshanholtz merged 2 commits into
sendgrid:mainfrom
IObert:main

Conversation

@IObert

@IObert IObert commented Feb 28, 2022

Copy link
Copy Markdown
Contributor

Fixes

Closes #1343

There's a broken link on the npm pages of each package because npm isn't aware of the notion of the monorepo. Hard-coding the URL to the image is the easiest solution to this problem.

https://www.npmjs.com/package/@sendgrid/client
Screenshot 2022-02-28 at 14 31 57

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works -> Not applicable
  • I have added the necessary documentation about the functionality in the appropriate .md file -> Not applicable
  • I have added inline documentation to the code I modified -> Not applicable

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken sticker and link in the readme file

2 participants